From da53ecef9ad4aa3a8f57c8d90ad16a3e772be85b Mon Sep 17 00:00:00 2001 From: "Karl O. Pinc" Date: Tue, 16 Jul 2024 07:51:33 -0500 Subject: [PATCH] Better response variable name db_changed -> report_success --- src/pgwui_upload/views/upload.py | 2 +- tests/views/test_upload.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/pgwui_upload/views/upload.py b/src/pgwui_upload/views/upload.py index e5cb7f4..36f195d 100644 --- a/src/pgwui_upload/views/upload.py +++ b/src/pgwui_upload/views/upload.py @@ -186,6 +186,6 @@ def upload_view(request): set_upload_response('pgwui_upload', request, response) - if response['db_changed']: + if response['report_success']: log_success(response) return response diff --git a/tests/views/test_upload.py b/tests/views/test_upload.py index 8467770..2052e2d 100644 --- a/tests/views/test_upload.py +++ b/tests/views/test_upload.py @@ -37,7 +37,7 @@ pytest_plugins = ("pgwui",) # Constants CHANGED_RESPONSE = { 'db': 'somedb', - 'db_changed': True, + 'report_success': True, 'filename': 'file', 'lines': 5, 'null_rep': 'NULL', @@ -47,7 +47,7 @@ CHANGED_RESPONSE = { 'user': 'someuser', } -UNCHANGED_RESPONSE = {'db_changed': False} +UNCHANGED_RESPONSE = {'report_success': False} # A "upload form" UPLOAD_FORM_W_LIT_CHECKED = {'literal_col_headings': True} @@ -184,7 +184,7 @@ def test_upload_view_db_not_changed(undecorate, mock_log_success): assert mock_log_success.call_count == 0 -def test_upload_view_db_changed(undecorate, mock_log_success): +def test_upload_view_report_success(undecorate, mock_log_success): '''When the db did change from CSV input log_success() is called''' response = CHANGED_RESPONSE result = undecorate(response) -- 2.34.1